Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Kafka Logger. #1312

Merged
merged 4 commits into from
Mar 25, 2020
Merged

Kafka Logger. #1312

merged 4 commits into from
Mar 25, 2020

Conversation

Akayeshmantha
Copy link
Member

Adding kafka plugin.

Issues resolved
Fix #1259

@Akayeshmantha
Copy link
Member Author

@moonming @membphis can we review the PR ?

@membphis
Copy link
Member

@Akayeshmantha please rebase your branch with master branch

@Akayeshmantha Akayeshmantha force-pushed the patch12 branch 3 times, most recently from 8cb7b1c to 0b5ee35 Compare March 23, 2020 11:27
@Akayeshmantha
Copy link
Member Author

@membphis done

membphis
membphis previously approved these changes Mar 24, 2020
@membphis membphis dismissed their stale review March 24, 2020 13:32

miss doc

@membphis
Copy link
Member

@Akayeshmantha It missing doc now.

The source code is fine.

@Akayeshmantha
Copy link
Member Author

Added @membphis. And rebased with the master 😃

@moonming moonming merged commit 8adafa3 into apache:master Mar 25, 2020
@membphis
Copy link
Member

@Akayeshmantha many thx

SaberMaster pushed a commit to SaberMaster/incubator-apisix that referenced this pull request Jun 30, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to kafka publisher plugin
3 participants