feature: supported to use host name in upstream #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
membphis
changed the title
moonming
changed the title
membphis
changed the title
moonming
requested changes
Sep 18, 2019
| @@ -29,6 +29,10 @@ apisix: | |||
| # udp: # UDP proxy port list | |||
| # - 9200 | |||
| # - 9211 | |||
| dns_resolver: # use 114.114.114.114 as default DNS resolver, disable IPv6 and enable local DNS. | |||
| - 114.114.114.114 | |||
There was a problem hiding this comment.
114.114.114.114 is only friendly for Chinese. I think 8.8.8.8 or 1.1.1.1 is better.
There was a problem hiding this comment.
After the international lover feel that it is wrong, we modify it better.
| @@ -38,7 +38,7 @@ http { | |||
|
|
|||
| lua_socket_log_errors off; | |||
|
|
|||
| resolver ipv6=off local=on; | |||
| resolver 114.114.114.114 ipv6=off local=on; | |||
| local host, port = core.utils.parse_addr(addr) | ||
| if not ipmatcher.parse_ipv4(host) and | ||
| not ipmatcher.parse_ipv6(host) then | ||
| local ip_info = core.utils.dns_parse(dns_resolver, host) |
There was a problem hiding this comment.
we should not drop the error msg of dns_parse. if the domain is invalid or timeout, what's the result? we should add test cases for that.
|
@membphis please take a look comments. |
This was referenced Sep 23, 2019
you'd better create new issue if you leave new message when we merged some PR already. |
|
no, I commented before merged.
YuanSheng Wang <notifications@github.com> 于2019年9月23日周一 下午8:54写道：
… @membphis <https://github.com/membphis> please take a look comments.
you'd better create new issue if you leave new message when we merged some
PR already.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#522>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGJZBK4V553CABF25FBU6WDQLC4BTANCNFSM4IW6EZIQ>
.
|
|
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will fix: #21