bugfix: key-auth plugin cannot run accurately in the case of multiple consumers(branch: master) #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mers(branch: master)
membphis
reviewed
Nov 10, 2019
t/plugin/key-auth.t
Outdated
| GET /hello | ||
| GET /add_more_consumer | ||
| --- pipelined_requests eval | ||
| ["GET /add_more_consumer", "GET /hello"] | ||
| --- more_headers | ||
| apikey: auth-one |
There was a problem hiding this comment.
apikey: auth-one -> apikey: auth-13, test the new code logic.
|
@Beckjiang And please update the version to |
membphis
approved these changes
Nov 10, 2019
|
@Beckjiang Merged, many thanks. |
moonming
pushed a commit
to moonming/apisix
that referenced
this pull request
Nov 10, 2019
moonming
pushed a commit
that referenced
this pull request
Nov 10, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix the logical error in
apisix/consumer.luaand improve the test case.Full changelog
Issues resolved
The improved test case run in branch master.
Run in this branch.
