Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

test_optimizer.test_nadam has fixed seed that can mask flakiness #11736

Closed
szha opened this issue Jul 13, 2018 · 2 comments
Closed

test_optimizer.test_nadam has fixed seed that can mask flakiness #11736

szha opened this issue Jul 13, 2018 · 2 comments
Labels
Flaky Test

Comments

@szha
Copy link
Member

szha commented Jul 13, 2018

The unit test in title have been using fixed seed to mask flakiness. Suggested action:

  1. Evaluate whether the test is flaky without fixed seed. If not, remove seed. Else move to 2
  2. If test is flaky, determine whether it's an actual uncaught edge case. If so, fix the operator. Else move to 3
  3. If numerical instability is inevitable, adjust tolerance level appropriately.
@apeforest
Copy link
Contributor

@szha Thanks for filing this issue. We will investigate these Flaky tests.

@apeforest
Copy link
Contributor

Thannks for filing this issue. We will investigate this Flaky test

@access2rohit access2rohit mentioned this issue Aug 14, 2018
Merged
5 tasks
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
Flaky Test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@szha @sandeep-krishnamurthy @apeforest