feat: saved query preview modal #11135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nytai
reviewed
Oct 2, 2020
| @@ -214,6 +214,7 @@ export interface ListViewProps<T extends object = any> { | |||
| sticky?: boolean; | |||
| fullHeight?: boolean; | |||
| manualSortBy?: boolean; | |||
| previewRowId?: number; | |||
There was a problem hiding this comment.
can we rename this prop to highlightRowId or something that's a little less tied to the current use case?
lilykuang
force-pushed
the
lily/saved-query-preview
branch
from
f873236 to
f6d597b
Compare
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://www.loom.com/share/7c507cabafb4443fa9e76997bb8cdc72
TEST PLAN
ADDITIONAL INFORMATION