feat: add UUID column to saved_query for export/import #11397
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11397 +/- ##
==========================================
- Coverage 66.64% 62.13% -4.52%
==========================================
Files 861 862 +1
Lines 40935 40973 +38
Branches 3700 3700
==========================================
- Hits 27283 25460 -1823
- Misses 13554 15333 +1779
- Partials 98 180 +82
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| } | ||
|
|
||
|
|
||
| def add_uuids(session, batch_size=default_batch_size): |
There was a problem hiding this comment.
Maybe you can import these functions from the earlier migration script to DRY and also indicate they are related?
There was a problem hiding this comment.
I was on the fence about doing this, because it requires small changes in the previous script, and changing a previous migration script seems dangerous.
In this case it seems safe enough... let me know what you think.
There was a problem hiding this comment.
Makes sense. Didn't know updates were needed, in that case I'm OK with either approach.
Someone committed a DB migration to master after I created my script, so now we have two HEADS in the Alembic DAG. Let me fix that. |
* Add UUID to saved_query * Reuse function from previous migration * Point to new head
mistercrunch
added
🏷️ bot
SUMMARY
This PR adds the
ImportMixinbase class to theSavedQuerymodel, as well as adding a DB migration that adds and populates the column.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
superset db upgradeand verified that saved queries have a UUIDsuperset db downgrade af30ca79208fand verified that column is removed.ADDITIONAL INFORMATION