From 15a54e6e99441fe1a3823fdae9afb7bfabe1f623 Mon Sep 17 00:00:00 2001 From: Vinish Reddy Date: Wed, 18 Dec 2024 23:52:58 -0800 Subject: [PATCH] Use getStorageLocation in interface --- .../main/java/org/apache/xtable/spi/sync/CatalogSync.java | 2 +- .../java/org/apache/xtable/spi/sync/CatalogSyncClient.java | 2 +- .../java/org/apache/xtable/spi/sync/TestCatalogSync.java | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/xtable-api/src/main/java/org/apache/xtable/spi/sync/CatalogSync.java b/xtable-api/src/main/java/org/apache/xtable/spi/sync/CatalogSync.java index 0abdfd377..0cbebbfcf 100644 --- a/xtable-api/src/main/java/org/apache/xtable/spi/sync/CatalogSync.java +++ b/xtable-api/src/main/java/org/apache/xtable/spi/sync/CatalogSync.java @@ -87,7 +87,7 @@ private CatalogSyncStatus syncCatalog( catalogSyncClient.createDatabase(tableIdentifier.getDatabaseName()); } TABLE catalogTable = catalogSyncClient.getTable(tableIdentifier); - String storageDescriptorLocation = catalogSyncClient.getStorageDescriptorLocation(catalogTable); + String storageDescriptorLocation = catalogSyncClient.getStorageLocation(catalogTable); if (catalogTable == null) { catalogSyncClient.createTable(table, tableIdentifier); } else if (hasStorageDescriptorLocationChanged( diff --git a/xtable-api/src/main/java/org/apache/xtable/spi/sync/CatalogSyncClient.java b/xtable-api/src/main/java/org/apache/xtable/spi/sync/CatalogSyncClient.java index 6eb21ab64..a77db0183 100644 --- a/xtable-api/src/main/java/org/apache/xtable/spi/sync/CatalogSyncClient.java +++ b/xtable-api/src/main/java/org/apache/xtable/spi/sync/CatalogSyncClient.java @@ -35,7 +35,7 @@ public interface CatalogSyncClient
extends AutoCloseable { String getCatalogName(); /** Returns the storage location of the table synced to the catalog. */ - String getStorageDescriptorLocation(TABLE table); + String getStorageLocation(TABLE table); /** Checks whether a database exists in the catalog. */ boolean hasDatabase(String databaseName); diff --git a/xtable-api/src/test/java/org/apache/xtable/spi/sync/TestCatalogSync.java b/xtable-api/src/test/java/org/apache/xtable/spi/sync/TestCatalogSync.java index 213ccbed0..b54c4704e 100644 --- a/xtable-api/src/test/java/org/apache/xtable/spi/sync/TestCatalogSync.java +++ b/xtable-api/src/test/java/org/apache/xtable/spi/sync/TestCatalogSync.java @@ -90,9 +90,9 @@ void testSyncTable() { when(mockClient2.getTable(tableIdentifier2)).thenReturn(null); when(mockClient3.getTable(tableIdentifier3)).thenReturn(mockTable); - when(mockClient1.getStorageDescriptorLocation(any())).thenReturn("/tmp/test_changed"); - when(mockClient2.getStorageDescriptorLocation(any())).thenReturn("/tmp/test"); - when(mockClient3.getStorageDescriptorLocation(any())).thenReturn("/tmp/test"); + when(mockClient1.getStorageLocation(any())).thenReturn("/tmp/test_changed"); + when(mockClient2.getStorageLocation(any())).thenReturn("/tmp/test"); + when(mockClient3.getStorageLocation(any())).thenReturn("/tmp/test"); when(mockClient4.getCatalogName()).thenReturn("catalogName4");