From 17d1447f9c557ba88effe041f7f27376855635a1 Mon Sep 17 00:00:00 2001 From: David Jacot Date: Tue, 4 Feb 2025 14:34:57 +0100 Subject: [PATCH] MINOR: Fix Benchmark sys tests (#18796) This patch fixes the Benchmark system tests. We misconfigured the quorum in https://github.com/apache/kafka/commit/bc7b87001bfd641f93105eaa1e0326bdaf15b55d. ``` ================================================================================ SESSION REPORT (ALL TESTS) ducktape version: 0.12.0 session_id: 2025-02-04--001 run time: 57 minutes 27.169 seconds tests run: 62 passed: 62 flaky: 0 failed: 0 ignored: 0 ================================================================================ ``` Reviewers: PoAn Yang , Christo Lolov --- .../benchmarks/core/benchmark_test.py | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/tests/kafkatest/benchmarks/core/benchmark_test.py b/tests/kafkatest/benchmarks/core/benchmark_test.py index f66f759d46c95..277f8ed264cd9 100644 --- a/tests/kafkatest/benchmarks/core/benchmark_test.py +++ b/tests/kafkatest/benchmarks/core/benchmark_test.py @@ -62,9 +62,9 @@ def start_kafka(self, security_protocol, interbroker_security_protocol, version, @parametrize(acks=1, topic=TOPIC_REP_THREE, metadata_quorum=quorum.isolated_kraft) @parametrize(acks=-1, topic=TOPIC_REP_THREE, metadata_quorum=quorum.isolated_kraft) @matrix(acks=[1], topic=[TOPIC_REP_THREE], message_size=[10, 100, 1000, 10000, 100000], - compression_type=["none", "snappy"], security_protocol=['SSL'], tls_version=['TLSv1.2', 'TLSv1.3'], metadata_quorum=quorum.isolated_kraft) + compression_type=["none", "snappy"], security_protocol=['SSL'], tls_version=['TLSv1.2', 'TLSv1.3'], metadata_quorum=[quorum.isolated_kraft]) @matrix(acks=[1], topic=[TOPIC_REP_THREE], message_size=[10, 100, 1000, 10000, 100000], - compression_type=["none", "snappy"], security_protocol=['PLAINTEXT'], metadata_quorum=quorum.isolated_kraft) + compression_type=["none", "snappy"], security_protocol=['PLAINTEXT'], metadata_quorum=[quorum.isolated_kraft]) @parametrize(acks=1, topic=TOPIC_REP_THREE, num_producers=3, metadata_quorum=quorum.isolated_kraft) def test_producer_throughput(self, acks, topic, num_producers=1, message_size=DEFAULT_RECORD_SIZE, compression_type="none", security_protocol='PLAINTEXT', tls_version=None, client_version=str(DEV_BRANCH), @@ -97,8 +97,8 @@ def test_producer_throughput(self, acks, topic, num_producers=1, message_size=DE @cluster(num_nodes=7) @matrix(security_protocol=['SSL'], interbroker_security_protocol=['PLAINTEXT'], tls_version=['TLSv1.2', 'TLSv1.3'], - compression_type=["none", "snappy"], metadata_quorum=quorum.isolated_kraft) - @matrix(security_protocol=['PLAINTEXT'], compression_type=["none", "snappy"], metadata_quorum=quorum.isolated_kraft) + compression_type=["none", "snappy"], metadata_quorum=[quorum.isolated_kraft]) + @matrix(security_protocol=['PLAINTEXT'], compression_type=["none", "snappy"], metadata_quorum=[quorum.isolated_kraft]) def test_long_term_producer_throughput(self, compression_type="none", security_protocol='PLAINTEXT', tls_version=None, interbroker_security_protocol=None, client_version=str(DEV_BRANCH), @@ -155,9 +155,9 @@ def test_long_term_producer_throughput(self, compression_type="none", @cluster(num_nodes=8) @matrix(security_protocol=['SSL'], interbroker_security_protocol=['PLAINTEXT'], tls_version=['TLSv1.2', 'TLSv1.3'], - compression_type=["none", "snappy"], metadata_quorum=quorum.isolated_kraft) - @matrix(security_protocol=['PLAINTEXT'], compression_type=["none", "snappy"], metadata_quorum=quorum.isolated_kraft) - @matrix(security_protocol=['SASL_PLAINTEXT', 'SASL_SSL'], compression_type=["none", "snappy"], metadata_quorum=quorum.isolated_kraft) + compression_type=["none", "snappy"], metadata_quorum=[quorum.isolated_kraft]) + @matrix(security_protocol=['PLAINTEXT'], compression_type=["none", "snappy"], metadata_quorum=[quorum.isolated_kraft]) + @matrix(security_protocol=['SASL_PLAINTEXT', 'SASL_SSL'], compression_type=["none", "snappy"], metadata_quorum=[quorum.isolated_kraft]) def test_end_to_end_latency(self, compression_type="none", security_protocol="PLAINTEXT", tls_version=None, interbroker_security_protocol=None, client_version=str(DEV_BRANCH), broker_version=str(DEV_BRANCH), metadata_quorum=quorum.isolated_kraft): @@ -187,8 +187,8 @@ def test_end_to_end_latency(self, compression_type="none", security_protocol="PL @cluster(num_nodes=8) @matrix(security_protocol=['SSL'], interbroker_security_protocol=['PLAINTEXT'], tls_version=['TLSv1.2', 'TLSv1.3'], - compression_type=["none", "snappy"], metadata_quorum=quorum.isolated_kraft) - @matrix(security_protocol=['PLAINTEXT'], compression_type=["none", "snappy"], metadata_quorum=quorum.isolated_kraft) + compression_type=["none", "snappy"], metadata_quorum=[quorum.isolated_kraft]) + @matrix(security_protocol=['PLAINTEXT'], compression_type=["none", "snappy"], metadata_quorum=[quorum.isolated_kraft]) def test_producer_and_consumer(self, compression_type="none", security_protocol="PLAINTEXT", tls_version=None, interbroker_security_protocol=None, client_version=str(DEV_BRANCH), broker_version=str(DEV_BRANCH), metadata_quorum=quorum.isolated_kraft): @@ -235,8 +235,8 @@ def test_producer_and_consumer(self, compression_type="none", security_protocol= @cluster(num_nodes=8) @matrix(security_protocol=['SSL'], interbroker_security_protocol=['PLAINTEXT'], tls_version=['TLSv1.2', 'TLSv1.3'], - compression_type=["none", "snappy"], metadata_quorum=quorum.isolated_kraft) - @matrix(security_protocol=['PLAINTEXT'], compression_type=["none", "snappy"], metadata_quorum=quorum.isolated_kraft) + compression_type=["none", "snappy"], metadata_quorum=[quorum.isolated_kraft]) + @matrix(security_protocol=['PLAINTEXT'], compression_type=["none", "snappy"], metadata_quorum=[quorum.isolated_kraft]) def test_consumer_throughput(self, compression_type="none", security_protocol="PLAINTEXT", tls_version=None, interbroker_security_protocol=None, num_consumers=1, client_version=str(DEV_BRANCH), broker_version=str(DEV_BRANCH), metadata_quorum=quorum.isolated_kraft):