Skip to content

Commit 2dbee43

Browse files
committed
[MNG-7634] Revert MNG-5982 and MNG-7417
This closes #917
1 parent 4adaf2a commit 2dbee43

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultArtifactDescriptorReader.java

+12-4
Original file line numberDiff line numberDiff line change
@@ -253,8 +253,11 @@ private Model loadPom(
253253
modelRequest.setValidationLevel(ModelBuildingRequest.VALIDATION_LEVEL_MINIMAL);
254254
modelRequest.setProcessPlugins(false);
255255
modelRequest.setTwoPhaseBuilding(false);
256-
modelRequest.setSystemProperties(toProperties(session.getSystemProperties()));
257-
modelRequest.setUserProperties(toProperties(session.getUserProperties()));
256+
// This merge is on purpose because otherwise user properties would override model
257+
// properties in dependencies the user does not know. See MNG-7563 for details.
258+
modelRequest.setSystemProperties(
259+
toProperties(session.getUserProperties(), session.getSystemProperties()));
260+
modelRequest.setUserProperties(new Properties());
258261
modelRequest.setModelCache(modelCacheFactory.createCache(session));
259262
modelRequest.setModelResolver(new DefaultModelResolver(
260263
session,
@@ -303,9 +306,14 @@ private Model loadPom(
303306
}
304307
}
305308

306-
private Properties toProperties(Map<String, String> map) {
309+
private Properties toProperties(Map<String, String> dominant, Map<String, String> recessive) {
307310
Properties props = new Properties();
308-
props.putAll(map);
311+
if (recessive != null) {
312+
props.putAll(recessive);
313+
}
314+
if (dominant != null) {
315+
props.putAll(dominant);
316+
}
309317
return props;
310318
}
311319

0 commit comments

Comments
 (0)