Skip to content

Commit 7db942b

Browse files
committed
[MNG-7634] Revert MNG-5982 and MNG-7417
This closes #917
1 parent 61f1f01 commit 7db942b

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultArtifactDescriptorReader.java

+14-4
Original file line numberDiff line numberDiff line change
@@ -274,8 +274,11 @@ private Model loadPom( RepositorySystemSession session, ArtifactDescriptorReques
274274
modelRequest.setValidationLevel( ModelBuildingRequest.VALIDATION_LEVEL_MINIMAL );
275275
modelRequest.setProcessPlugins( false );
276276
modelRequest.setTwoPhaseBuilding( false );
277-
modelRequest.setSystemProperties( toProperties( session.getSystemProperties() ) );
278-
modelRequest.setUserProperties( toProperties( session.getUserProperties() ) );
277+
// This merge is on purpose because otherwise user properties would override model
278+
// properties in dependencies the user does not know. See MNG-7563 for details.
279+
modelRequest.setSystemProperties(
280+
toProperties( session.getUserProperties(), session.getSystemProperties() ) );
281+
modelRequest.setUserProperties( new Properties() );
279282
modelRequest.setModelCache( DefaultModelCache.newInstance( session ) );
280283
modelRequest.setModelResolver( new DefaultModelResolver( session, trace.newChild( modelRequest ),
281284
request.getRequestContext(), artifactResolver,
@@ -328,10 +331,17 @@ private Model loadPom( RepositorySystemSession session, ArtifactDescriptorReques
328331
}
329332
}
330333

331-
private Properties toProperties( Map<String, String> map )
334+
private Properties toProperties( Map<String, String> dominant, Map<String, String> recessive )
332335
{
333336
Properties props = new Properties();
334-
props.putAll( map );
337+
if ( recessive != null )
338+
{
339+
props.putAll( recessive );
340+
}
341+
if ( dominant != null )
342+
{
343+
props.putAll( dominant );
344+
}
335345
return props;
336346
}
337347

0 commit comments

Comments
 (0)