Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add start-after support for list #2063

Closed
3 tasks done
Xuanwo opened this issue Apr 22, 2023 · 11 comments
Closed
3 tasks done

feat: Add start-after support for list #2063

Xuanwo opened this issue Apr 22, 2023 · 11 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Apr 22, 2023

Some services support list from start-after, like s3, gcs. We can provide this feature to allow users to resume their list process.

Tasks

@Xuanwo Xuanwo added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 22, 2023
@lexcao
Copy link
Contributor

lexcao commented Apr 22, 2023

Hi @Xuanwo , I am willing to help on this.

@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 22, 2023

Great! Have fun! I will assign you to the first task.

@lexcao
Copy link
Contributor

lexcao commented Apr 22, 2023

Hi @Xuanwo, I am willing to help the rest of 2 tasks.

@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 22, 2023

Hi @Xuanwo, I am willing to help the rest of 2 tasks.

Great! Maybe we can add a behavior test case for start after first🤩

@lexcao
Copy link
Contributor

lexcao commented Apr 22, 2023

Thank you!
Sure, I will give it a try.

@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 22, 2023

I have assigned this issue to you, take your time and have fun!

@Xuanwo Xuanwo mentioned this issue Apr 23, 2023
4 tasks
@lexcao
Copy link
Contributor

lexcao commented Apr 23, 2023

Hi, @Xuanwo , need help with the details about behavior test before coding.

Here is what the structure of the behavior test for test_list_with_start_after could be:

// in file tests/behavior/list.rs
pub async fn test_list_with_start_after(op: Operator) -> Result<()> {
    // 1. check the capability
    // 2. write test data
    // 3. list with start-after
    // 4. assert the result
    // 5. clear data
}
  • Could you please help reviewing the structure? I want to confirm I am in the right way to add a behavior test.

  • How do I test it without implementing the real backend(e.g s3 and gcs)?

@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 23, 2023

  • Could you please help reviewing the structure? I want to confirm I am in the right way to add a behavior test.

LGTM!

  • How do I test it without implementing the real backend(e.g s3 and gcs)?

It's Ok to implement for s3 first.

@lexcao
Copy link
Contributor

lexcao commented Apr 23, 2023

Great, your quick response is appreciated.
I am going to code. 🚀

@lexcao
Copy link
Contributor

lexcao commented Apr 25, 2023

All sub-tasks finished, this issue could be closed as well.

@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 25, 2023

Thanks a lot!

@Xuanwo Xuanwo closed this as completed Apr 25, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants