From 7c38c01a461d9c83521fb157ca2e0121a08fd1b6 Mon Sep 17 00:00:00 2001 From: Alex Levenson Date: Mon, 13 Jul 2015 16:09:45 -0700 Subject: [PATCH] Surface subprocess stderr in merge script --- dev/merge_parquet_pr.py | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/dev/merge_parquet_pr.py b/dev/merge_parquet_pr.py index 8ebd887f17..621fcde807 100755 --- a/dev/merge_parquet_pr.py +++ b/dev/merge_parquet_pr.py @@ -79,11 +79,19 @@ def fail(msg): def run_cmd(cmd): - if isinstance(cmd, list): - return subprocess.check_output(cmd) - else: - return subprocess.check_output(cmd.split(" ")) - + try: + if isinstance(cmd, list): + return subprocess.check_output(cmd, stderr=subprocess.STDOUT) + else: + return subprocess.check_output(cmd.split(" "), stderr = subprocess.STDOUT) + except subprocess.CalledProcessError as e: + # this avoids hiding the stdout / stderr of failed processes + print 'Command failed: %s' % cmd + print 'With output:' + print '--------------' + print e.output + print '--------------' + raise e def continue_maybe(prompt): result = raw_input("\n%s (y/n): " % prompt)