Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bug] SnapshotSegmentAbortedTxnProcessorImpl contains thread safety issues #22116

Open
1 of 2 tasks
lhotari opened this issue Feb 26, 2024 · 2 comments · May be fixed by #22384
Open
1 of 2 tasks

[Bug] SnapshotSegmentAbortedTxnProcessorImpl contains thread safety issues #22116

lhotari opened this issue Feb 26, 2024 · 2 comments · May be fixed by #22384
Assignees

Comments

@lhotari
Copy link
Member

lhotari commented Feb 26, 2024

Search before asking

  • I searched in the issues and found nothing similar.

Version

master

Minimal reproduce step

There are several thread safety issues in SnapshotSegmentAbortedTxnProcessorImpl class.
examples:

if (indexes.size() != 0) {
persistentWorker.sequenceID.set(indexes.get(indexes.lastKey()).sequenceID + 1);
}


What did you expect to see?

Multi-threading code should be thread safe.

What did you see instead?

Non thread-safe code.

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@lhotari
Copy link
Member Author

lhotari commented Feb 26, 2024

related to #21304 and #22119

@nikam14
Copy link
Contributor

nikam14 commented Mar 28, 2024

@lhotari can you review above mentioned PR.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants