Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Doc] Apache Shiro docs for modern Java: virtual threads , structured concurrency and scoped value #1862

Open
2 tasks done
hrstoyanov opened this issue Nov 5, 2024 · 1 comment

Comments

@hrstoyanov
Copy link

Search before asking

  • I had searched in the issues and found no similar issues.

Documentation Related

Apache Shiro docs discuss thread association of Subject, but modern Java now offers scoped values that eliminate the need for thread locals and structured concurrency for proper threads cleanup.

I would appreciate if the Apache Shiro docs are extended with these topics, some practical code is shown, especially for the custom Subject builder api

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@lprimak
Copy link
Contributor

lprimak commented Nov 5, 2024

Largely agree, but neither Structured Concurrency nor Scoped Values are final yet.
Maybe just a bit of patience or a "preview note" would be prudent.

There is also an issue of "when" Shiro may adopt those concepts, since that will force minimal Java version to be quite high, or force us to do some kind of MR-Jar of plugin situation

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants