Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Vertical dimension sort by time between threads #1657

Closed
1 of 4 tasks
tuohai666 opened this issue Sep 11, 2018 · 2 comments
Closed
1 of 4 tasks

Vertical dimension sort by time between threads #1657

tuohai666 opened this issue Sep 11, 2018 · 2 comments
Assignees
Labels
backend OAP backend related. wontfix This will not be worked on
Milestone

Comments

@tuohai666
Copy link
Member

Please answer these questions before submitting your issue.

  • Why do you submit this issue?
  • Question or discussion
  • Bug
  • Requirement
  • Feature or performance improvement

Requirement or improvement

The picture below is from a tracing in Sharding-Sphere:

1a

There are 4 threads appear in this tracing: the main thread, Sharding-Sphere-0, Sharding-Sphere-1, Sharding-Sphere-2.
The tracing order in main thread is correct: parsing -> getConnection -> executeSQL -> close.
But it's disordered between threads: Sharding-Sphere-0, Sharding-Sphere-1, Sharding-Sphere-2 should happen after getConnection while before close.
I believe skywalking didn't sort tracing beween threads, and this kind of sort is the requirement.

@wu-sheng
Copy link
Member

Yes, this feature is still missing. I don't know, maybe 6.0.0-RC to fix this? @peng-yongsheng thoughts?

@wu-sheng wu-sheng added bug Something isn't working and you are sure it's a bug! TBD To be decided later, need more discussion or input. backend OAP backend related. labels Sep 11, 2018
@wu-sheng
Copy link
Member

Closing. We have shardingsphere plugin from the official team, today.

@wu-sheng wu-sheng removed TBD To be decided later, need more discussion or input. bug Something isn't working and you are sure it's a bug! labels May 22, 2019
@wu-sheng wu-sheng added this to the 6.2.0 milestone May 22, 2019
@wu-sheng wu-sheng added the wontfix This will not be worked on label May 22, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backend OAP backend related. wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants