[SPARK-49773][SQL] uncaught Java exception from make_timestamp() with bad timezone #48260
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
reviewed
Sep 26, 2024
| @@ -3267,6 +3267,12 @@ | |||
| }, | |||
| "sqlState" : "42000" | |||
| }, | |||
| "INVALID_ZONE_OFFSET": { | |||
There was a problem hiding this comment.
shall we clearly say it's time zone?
cloud-fan
reviewed
Sep 26, 2024
| @@ -3267,6 +3267,12 @@ | |||
| }, | |||
| "sqlState" : "42000" | |||
| }, | |||
| "INVALID_ZONE_OFFSET": { | |||
| "message": [ | |||
| "<message>. ZoneOffset represents the time difference from UTC and must be in the range from -18:00 to +18:00." | |||
There was a problem hiding this comment.
it's a bad practice to pass in the entire message. We can just say the zone offset is invalid, and we keep the original error as the causedBy of this error.
There was a problem hiding this comment.
Not sure why we need to preserve the caused by. Or is that merely for the stack trace?
There was a problem hiding this comment.
yea, and also to retain the original error message from the JDK library.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to fix the uncaught Java exception from
make_timestamp()with bad timezoneWhy are the changes needed?
To improve the error message
Does this PR introduce any user-facing change?
No API changes, but the user-facing error message is changed:
Before
After
How was this patch tested?
CI
Was this patch authored or co-authored using generative AI tooling?
No