[explore] When switching from Simple to Custom SQL for a filter, it translates INT to string

[zuzana-vej]

Simple SQL correctly encodes the values as INTegers. and technically it's displaying incorrectly views IN ('5', '10') even though it's encoded correctly and the query is working - therefore this is a minor issue but can confuse users.

Expected results

Displayed as integer in the Custom SQL box.

Actual results

Transforms into string in the Custom SQL box.

Screenshots

Filter:

Generated SQL Query

How to reproduce the bug

1. Go to Explore
2. Create chart and go to WHERE filter box
3. Specify multiple IN integer values
4. See error

Environment

(please complete the following information):

• superset version: master
• python version: python --version
• node.js version: node -v

Checklist

Make sure to follow these steps before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

This has been introduced a while back - some time in September, but user consider it a feature request, not a bug.

[zuzana-vej]

Related bug: #11639

[junlincc]

There are few other issues(old or regression) around this area that we would like to address together. Tagging this issue Hold! and removing original assignee @michael-s-molina, thanks for all the investigation and testing!

Problem 1
Select a simple text filter like City
Switch to Custom SQL and change the value
It will present an error because the generated WHERE clause is invalid
To fix the user has to enter the quotes and double quotes manually

Problem 2:
Create a new Custom SQL filter like “City” = ‘Las Vegas’
Switch to Simple and fill a different filter like Month = 10
Switch back to Custom SQL and you will see that the value showing is “City” = ‘Las Vegas’ but if you select the text area the value will change to Month = 10

Problem 3:
Enable filter suggestions in dataset configuration
Select a date as a filter
All the suggestions are in a format not accepted by the database which will result in an error

cc @villebro @kgabryje
FYI @eugeniamz

[villebro]

FYI this was an old bug, not a regression caused by recent changes.