-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Global] Revisit open menu on hover #13257
Comments
@ktmud |
In the long term, I'm a fan of @junlincc 's proposal... just moving to SIP-34's layout. In the meantime, there are probably other places one might overshoot with the mouse and run into similar issues. Option 2 is reasonable enough, but I'm not sure it will solve the problem in other areas. Option 3 is intriguing to me... we could do it with JS, or we might be able to do it with a little CSS like this little demo I just threw together. |
@rusackas CSS delay looks cool. I did some testing and felt 250~300ms is the most comfortable. |
"When creating/editing a chart, the save button lines up underneath a drop down to navigate to SQL Lab. The hover area that expands the drop down is pretty large. If a user (me) wanted to save their work on the chart (I did), they might inadvertently trigger the hover to expand the drop down and click through to the SQL editor losing their work on the chart (doh! it happened to me). cc @Steejay we have an open ticket to track this issue. ^ |
For what it's worth I would prefer to replace "open on hover" with "open on click". Open on click is a pretty common pattern in other apps and would prevent accidental menu opens. Hope this is the right place to share this kind of feedback/opinion. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
I think this one has more or less settled out in controversy by now, and the run/save buttons that were causing a potential issue are no longer in that problematic spot (hooray!). I'll close this as stale since it's been over a year since anyone weighed in on this. If we still want to tackle any permutation of this as a community, I'd say we should open up a new Ideas thread and weigh the pros/cons there while taking the updated layout and other details into effect. |
We DON't have to change the current behavior, just creating an issue in case this comment got slip through the cracks.
@rusackas I'm finding a case where hovering to show menu might have become an inconvenience:
showing-menu-on-hover.mp4
When saving chart, I wanted to click on the "Save" button, but if I move the mouse too fast, it will trigger open the hover menu and when I moved back to the position of the "Save" button and click, I would accidentally click on the menu and lost all my changes to the chart---which is quite annoying.
I'm wondering if we can:
to avoid users accidentally clicking on the hovered menu item. We can do one or all of these if they make sense to you.
cc @junlincc @mihir174
Originally posted by @ktmud in #12025 (comment)
The text was updated successfully, but these errors were encountered: