[native filters] Select filter should allow user pick time column

[graceguo-supercat]

Current Select type filter component has time range control, but doesn't offer a time column control. For a dataset has multiple time columns, this will introduce a potential data quality issue.

Screenshots

This is screenshot to explain how filter_box is used in airbnb: A filter field, which is not a Date filter, it can still have time range and time column to limit the available choices. For example, with "Last 180 days" time range, this filter has 6 options, while without 180 days limit, it will show 8 options:

Environment

latest master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

I remember we discussed this issue in the next version of filter configure modal design. So i assume @junlincc is aware of this issue. I created an issue is to make sure backend can handle the extra query parameter for native filter component. cc @villebro

[junlincc]

hi @graceguo-supercat i do remember you brought this up in the discussion. can you further explain what potential data quality issue means? 😅

[villebro]

Good catch - do I understand correctly, that the need is to add the Time Column control to the Select and Range filters?

[graceguo-supercat]

can you further explain what potential data quality issue means?

for example, i have 2 time columns in a dataset, updated_time and created_time. In old filter_box, I can set time range as last 6 months and time column as updated_time. If native filter component not having time column control, this time range may add to created_time column, which will generate wrong options for this filter field.

[graceguo-supercat]

add the Time Column control to the Select and Range filters

yes. thank you!!

[junlincc]

@villebro @zhaoyongjie this is problematic, can we simply add a column select when there's 2 and more dataset is available, and make it dynamic?

[villebro]

We could fairly easily add a time column dropdown above "Time Range" here where the user could specify an optional time column if there are two or more time columns in a dataset:

[junlincc]

For quick fix that's ok.. eventually we need to remove the time range and blend it into a regular filter though. let's go for the easy solution for now! 😛