New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Giving proxyUrl with a password that contains special characters crashes #55

Closed

jirimoravcik opened this issue Oct 8, 2021 · 1 comment

Member

jirimoravcik commented Oct 8, 2021 •

edited

Loading

e.g. having proxyUrl = 'http://username:a6%6qgx12345@127.0.0.1:8888'
will throw Uncaught URIError: URI malformed (see https://github.com/apify/got-scraping/blob/master/src/agent/h1-proxy-agent.ts#L21)
I think it should work even with such passwords

ref sindresorhus/got#1317

The text was updated successfully, but these errors were encountered:

Contributor

szmarczak commented Oct 8, 2021

This is correct, %6q is malformed. You need to percent-encode % as %25:

http://username:a6%256qgx12345@127.0.0.1:8888

szmarczak closed this as completed

# for free to join this conversation on GitHub. Already have an account? # to comment