Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ronn --version probs: no ".pre" part, bogus GitHub URL for untagged releases, doesn't reflect add'l commits/changes #106

Open
apjanke opened this issue Jan 3, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@apjanke
Copy link
Owner

apjanke commented Jan 3, 2024

Here's what ronn --version does when you've bumped the version string in the source code.

$ ./bin/ronn --version
Ronn-NG v0.10.1
http://github.com/apjanke/ronn-ng/tree/0.10.1.pre4

If you haven't yet created that tag or release in GitHub yet, you get a 404 page for it.

image

Maybe we want to change the output for in-progress releases here. And maybe add an indicator for when it's running from a git commit that's not tagged as a version, including both additional commits and local changes.

Also, the version string in ronn --version doesn't include the ".preN" suffix for prereleases. Should probably add that; I like the version string to exactly reflect what you're running.

@apjanke apjanke self-assigned this Jan 3, 2024
@apjanke apjanke added the bug Something isn't working label Jan 3, 2024
@apjanke apjanke added this to ronn-ng Jan 4, 2024
@apjanke apjanke moved this to Low priority in ronn-ng Jan 4, 2024
@apjanke apjanke changed the title GitHub URL in ronn --version is bogus for untagged releases, doesn't reflect add'l commits/changes ronn --version probs: no ".pre" part, bogus GitHub URL for untagged releases, doesn't reflect add'l commits/changes Jan 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
Status: Low priority
Development

No branches or pull requests

1 participant