Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[4.0] Align ApolloQueryResult type and emitted result from the core API #12331

Open
jerelmiller opened this issue Jan 31, 2025 · 0 comments
Open

Comments

@jerelmiller
Copy link
Member

See #12327 as an example.

There are several cases where our TypeScript types and runtime behavior don't align. For example, the ApolloQueryResult type expects data to be a non-optional TData type. This is however incorrect as ObservableQuery will emit results where data is undefined or partial.

To ensure a good end-user experience, we'd like to make the type robust enough that data is a DeepPartial<TData> only when partial is set to true.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant