Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for custom deployment annotations to Helm chart #6253

Open
col opened this issue Nov 12, 2024 · 0 comments
Open

Add support for custom deployment annotations to Helm chart #6253

col opened this issue Nov 12, 2024 · 0 comments

Comments

@col
Copy link
Contributor

col commented Nov 12, 2024

Is your feature request related to a problem? Please describe.

I need to add some annotations to the deployment resource in order to use CircleCI Releases. Unfortunately the Router Helm chart does not provide this as a config option. Although my use case is quite specific I believe it's a fairly common requirement for people to need to add custom annotations to deployments.

This is already supported for deployment/pod labels via extraLabels and for pod annotations via podAnnotations but there is no support for deployment annotations.

Describe the solution you'd like

I'd like the same approach already used to support pod annotation but for deployments.

Example: deployment.yaml

{{- if .Values.deploymentAnnotations }}
{{- toYaml .Values.deploymentAnnotations | nindent 4 }}
{{- end }}

Describe alternatives you've considered

Not sure how else to achieve this without forking the Helm chart

Additional context

CircleCI Releases Doc: https://circleci.com/docs/release/configure-your-kubernetes-components/

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant