fix: revert --pct-syskeys 0 #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/commands/app-management.js
Outdated
| if (apiLevel < 24) { | ||
| // The monkey command could raise an issue as https://stackoverflow.com/questions/44860475/how-to-use-the-monkey-command-with-an-android-system-that-doesnt-have-physical | ||
| // but '--pct-syskeys 0' could cause another background process issue. https://github.com/appium/appium/issues/16941#issuecomment-1129837285 | ||
| // We should not add it to avoid it. |
There was a problem hiding this comment.
this last sentence is redundant
mykola-mokhnach
approved these changes
May 18, 2022
github-actions bot
pushed a commit
that referenced
this pull request
May 19, 2022
## [5.0.14](v5.0.13...v5.0.14) (2022-05-19) ### Bug Fixes * revert --pct-syskeys 0 ([#745](#745)) ([138ebf4](138ebf4))
|
🎉 This PR is included in version 5.0.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert the argument,
--pct-syskeys 0.activateAppdoes not useam startmethod for API level 24 with current implementation, so this revert also should not affect widely.Btw, I remember we use
start-activityinstead ofstartfor Android 8+, so this PR includes it.