Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade TLS Support to TLS 1.2 and Above in RunHTTPServer Function #792

Closed
nyxfqq opened this issue Jul 11, 2024 · 0 comments · Fixed by #793
Closed

Upgrade TLS Support to TLS 1.2 and Above in RunHTTPServer Function #792

nyxfqq opened this issue Jul 11, 2024 · 0 comments · Fixed by #793

Comments

@nyxfqq
Copy link

nyxfqq commented Jul 11, 2024

Description:

I've noticed that our server configuration, specifically in the RunHTTPServer function located in appleboy/gorush/router/server_normal.go, currently supports TLS 1.0 and TLS 1.1. Given the current year (2024), it's critical to acknowledge that TLS 1.2 has been widely adopted and is supported by nearly 100% of modern services. In contrast, only about 30% of sites continue to support TLS 1.0 primarily for compatibility reasons.

Justification:

  • Security Vulnerabilities: TLS 1.0 and TLS 1.1 contain known vulnerabilities that have been addressed in TLS 1.2 and later versions.
  • Industry Standards: The majority of web traffic today is secured via TLS 1.2 or higher, reflecting a shift in industry standards toward more robust encryption methods.
  • Client Compatibility: With TLS 1.2 being widely supported across browsers and devices, the removal of TLS 1.0 and TLS 1.1 support does not significantly impact compatibility with end users.

Proposed Solution:

To enhance the security posture of our application, I recommend updating the TLS support in the RunHTTPServer function to negotiate TLS 1.2 as the minimum version. This involves modifying the TLS configuration used by the server to disallow connections using TLS 1.0 and TLS 1.1.

Additional Information:

https://www.ssllabs.com/ssl-pulse/

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant