New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Marginalization mask #292

Closed

mlnpapez opened this issue Oct 18, 2024 · 1 comment · Fixed by #318

Assignees

Labels

Milestone

cirkit 0.2.0 (mur...

Collaborator

mlnpapez commented Oct 18, 2024

Hi,

The current implementation of the marginal query (https://github.com/april-tools/cirkit/blob/fb4554c5e8b418611115d2c56538e5ac67cf31c4/cirkit/backend/torch/queries.py#L19C7-L19C21) integrates all samples in the minibatch for the same set of indices. Would it be possible to apply a different set of indices for each sample in the minibatch? For example, it would be nice to have an option to use a marginalization mask (with a size equal to the minibatch).

Best regards,
Milan

loreloc added the enhancement label

loreloc added this to the cirkit 0.2.0 (murmur) milestone

Member

loreloc commented Oct 28, 2024 •

edited

Loading

Hi Milan, thanks for suggesting this! We plan to support the marginalization mask for the next cirkit version.

andreasgrv self-assigned this

andreasgrv mentioned this issue

Batched marginalisation mask #318

Merged

loreloc closed this as completed in #318

# for free to join this conversation on GitHub. Already have an account? # to comment