Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[APT-14] Determine way to speed up Move Aptos framework dependency download #5279

Open
babyface001 opened this issue Oct 25, 2022 · 9 comments
Assignees
Labels
community enhancement New feature or request move-cli Issues related to aptos move command move-deps stale-exempt Prevents issues from being automatically marked and closed as stale

Comments

@babyface001
Copy link

babyface001 commented Oct 25, 2022

🚀 Feature Request

split big repo

Motivation

framework dep is too long to download.

APT-14

@babyface001 babyface001 added the enhancement New feature or request label Oct 25, 2022
@JoshLind
Copy link
Contributor

JoshLind commented Nov 14, 2022

Can you provide more details? Parts of our repo require the move and framework deps, so this is unavoidable for these.

@babyface001
Copy link
Author

@JoshLind download framework dep will clone entry git repo, it 's too big.

if we split it into a separate repo, it will be small download.

@babyface001
Copy link
Author

we just need download framework repo, not entry aptos_core big repo.

@wrwg
Copy link
Contributor

wrwg commented Nov 15, 2022

The solution here is to use on-chain instead of git deps in the Move.toml. It is true that there is a large overhead here because for each Move package referenced, the full aptos-core repo needs to be downloaded.

@gregnazario gregnazario changed the title split repo Determine way to speed up Move Aptos framework dependency download Dec 21, 2022
@geekflyer geekflyer changed the title Determine way to speed up Move Aptos framework dependency download [APT-14] Determine way to speed up Move Aptos framework dependency download Dec 21, 2022
@movekevin movekevin added the move-cli Issues related to aptos move command label Jan 27, 2023
@lbmeiyi lbmeiyi moved this from 🆕 New to For Grabs in Move Language and Runtime Feb 16, 2023
@wrwg wrwg moved this from For Grabs to 🏗 In progress in Move Language and Runtime Feb 16, 2023
@wrwg wrwg added the move-deps label Feb 18, 2023
@wrwg
Copy link
Contributor

wrwg commented Feb 18, 2023

Similar as #5909

@github-actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label or comment - otherwise this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Apr 28, 2023
@wrwg wrwg removed the Stale label Apr 28, 2023
@wrwg wrwg moved this from 🏗 In progress to For Grabs in Move Language and Runtime Apr 28, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label or comment - otherwise this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Jun 13, 2023
@wrwg wrwg removed the Stale label Jun 13, 2023
@sausagee sausagee added the stale-exempt Prevents issues from being automatically marked and closed as stale label Jul 22, 2023
@brmataptos
Copy link
Contributor

I note that there is a --skip-fetch-latest-git-deps flag which you can use in case of poor network connection.

@brmataptos brmataptos self-assigned this Jul 24, 2023
@vgao1996 vgao1996 self-assigned this Jul 8, 2024
@vgao1996
Copy link
Contributor

vgao1996 commented Jul 8, 2024

Update: there's been more discussions on this issue recently, and here's what we plan to do to address this issue

  • Setting up a mirror repo that serves only the framework packages
    • This will be a read-only repo, with changes automatically synced from aptos-core using copy-bara
  • Exploring git shallow cloning so to avoid downloading unnecessary histories

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
community enhancement New feature or request move-cli Issues related to aptos move command move-deps stale-exempt Prevents issues from being automatically marked and closed as stale
Projects
Status: For Grabs
Development

No branches or pull requests

10 participants