From 9b2a4f83aa63d39e5c15e30c207b8a62d5e97c93 Mon Sep 17 00:00:00 2001 From: Jonathan King Date: Tue, 7 Mar 2023 17:29:48 -0500 Subject: [PATCH] Add missing warmup_num_steps parameter. warmup_decay_num_steps is a valid user argument but is not added to the config. This commit adds this argument to the configuration output. --- scripts/build_deepspeed_config.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/build_deepspeed_config.py b/scripts/build_deepspeed_config.py index 728101a3..eff67c96 100644 --- a/scripts/build_deepspeed_config.py +++ b/scripts/build_deepspeed_config.py @@ -248,9 +248,10 @@ params["warmup_max_lr"] = args.warmup_max_lr params["warmup_num_steps"] = args.warmup_num_steps elif(args.scheduler == "WarmupDecayLR"): - params["total_num_steps"] = args.warmup_decay_total_num_steps params["warmup_min_lr"] = args.warmup_decay_min_lr params["warmup_max_lr"] = args.warmup_decay_max_lr + params["warmup_num_steps"] = args.warmup_decay_num_steps + params["total_num_steps"] = args.warmup_decay_total_num_steps else: raise ValueError("Invalid scheduler")