Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

setup fails, torch is not a dependency #508

Open
cbaakman opened this issue Nov 20, 2024 · 1 comment
Open

setup fails, torch is not a dependency #508

cbaakman opened this issue Nov 20, 2024 · 1 comment

Comments

@cbaakman
Copy link

When I try to install openfold from pip, it fails with the message: no module named torch.

Apparently torch is required, but it's not a dependency in the setup.

@vaclavhanzl
Copy link
Contributor

vaclavhanzl commented Nov 20, 2024

@cbaakman I doubt that something like pip install openfold ever worked. While it is a nice idea, I'd be more inclined to believe that mamba install openfold may work one day. But for the moment following the rather complex instructions is a way to get it (most likely using the pl_upgrades branch). And you still need a nice sunny day and good luck. Or making a pull request or two.

Out of curiosity, I tried the pip install and yes, it fails with No module named 'torch' but it also says Downloading openfold-0.0.1.tar.gz (164 kB) which is not very convincing. Likely somebody had good intentions to make it work, once upon a time...

Thinking more about it, blindly installing packages without knowing that they exist and do have a trusted source can be a security issue. I have no knowledge about this particular one but it's maintainer seems to be juncongmoo who made quite some AI-related pip packages and similar juncongmoo exists on github, maybe you could please tell us something about the openfold pip package @juncongmoo ?

Edit: source code of the pip package seems to be from Mar 11 2023 and the openfold folder is identical to the one here in git, Mar 7 2023 commit 9b2a4f8. I do not see anything suspicious in few other files which are in the tgz. So I suppose this was a nice effort of @juncongmoo back then in 2023. And I wonder if it ever worked (my guess is no).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants