Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Age column to Report list pages #90

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

nublarsec
Copy link
Contributor

Closes #89.

This adds an Age column to the 3 current Report list pages, just like kubectl get vulnerabilityreport shows:

  • Vulnerability Reports
  • Config Audit Reports
  • CIS Kube Bench Reports

Screen Shot 2022-05-19 at 9 31 17 PM

It also has the absolute date as a tooltip on each Age value:
Screen Shot 2022-05-19 at 9 32 04 PM

A couple of side notes, @danielpacak perhaps you can weigh in:

  1. I wanted to use formatDuration() and LocaleDate from the Lens codebase to format datetimes. However they are not exported in the extension-specific NPM module, @k8slens/extensions, so I can't access them in the Starboard extension (as far as I can tell).
  2. Instead of using those, I brought over formatDuration() in a new folder called utils/.
  3. I also don't have access to UserStore from the Lens codebase, which means I can't see what the user's local timezone is for converting the absolute date. Instead I've just left it as UTC.

I'm somewhat new to Node/React/Electron—is there some other trick to being able to use these? Or are they not exported for a reason?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Age column to Report list pages
1 participant