fix(db): fix javadb downloading error handling (#7642)

nikpivkin · web-flow · commit 2c87f0cb794a · 2024-10-03T12:11:58.000Z
Signed-off-by: nikpivkin &lt;nikita.pivkin@smartforce.io&gt;
diff --git a/pkg/javadb/client.go b/pkg/javadb/client.go
@@ -104,10 +104,10 @@ func (u *Updater) downloadDB(ctx context.Context) error {
 		Quiet:     u.quiet,
 	}
 	if err := artifacts.Download(ctx, u.dbDir, downloadOpt); err != nil {
-		return xerrors.Errorf("failed to download vulnerability DB: %w", err)
+		return xerrors.Errorf("failed to download Java DB: %w", err)
 	}
 
-	return xerrors.New("failed to download Java DB from any source")
+	return nil
 }
 
 func Init(cacheDir string, javaDBRepositories []name.Reference, skip, quiet bool, registryOption ftypes.RegistryOptions) {

Original file line number	Diff line number	Diff line change
`@@ -104,10 +104,10 @@ func (u *Updater) downloadDB(ctx context.Context) error {`
`104`	`104`	`Quiet: u.quiet,`
`105`	`105`	`}`
`106`	`106`	`if err := artifacts.Download(ctx, u.dbDir, downloadOpt); err != nil {`
`107`		`- return xerrors.Errorf("failed to download vulnerability DB: %w", err)`
	`107`	`+ return xerrors.Errorf("failed to download Java DB: %w", err)`
`108`	`108`	`}`
`109`	`109`
`110`		`- return xerrors.New("failed to download Java DB from any source")`
	`110`	`+ return nil`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`func Init(cacheDir string, javaDBRepositories []name.Reference, skip, quiet bool, registryOption ftypes.RegistryOptions) {`