Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(cli): show info message only when --scanners is available #7032

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented Jun 27, 2024

Description

trivy convert shows the following message even though it doesn't have --scanners flag.

Before

$ trivy convert -f cyclonedx /tmp/with_vulns.json -o /dev/null
2024-06-27T07:33:52+04:00       INFO    "--format cyclonedx" disables security scanning. Specify "--scanners vuln" explicitly if you want to include vulnerabilities in the CycloneDX report.

After

$ trivy convert -f cyclonedx /tmp/with_vulns.json -o /dev/null

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263 knqyf263 self-assigned this Jun 27, 2024
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 force-pushed the fix/suppress_scanner_logs branch from 77279de to cf7b7ff Compare June 27, 2024 04:09
@knqyf263 knqyf263 marked this pull request as ready for review June 27, 2024 05:27
@knqyf263 knqyf263 requested a review from DmitriyLewen June 27, 2024 05:28
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@knqyf263 knqyf263 added this pull request to the merge queue Jun 27, 2024
Merged via the queue into aquasecurity:main with commit e9fc3e3 Jun 27, 2024
13 checks passed
@knqyf263 knqyf263 deleted the fix/suppress_scanner_logs branch June 27, 2024 06:34
skahn007gl pushed a commit to skahn007gl/trivy that referenced this pull request Jul 23, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants