Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(misconf): do not evaluate TF when a load error occurs #7109

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix(misconf): do not evaluate TF when a load error occurs #7109

merged 1 commit into from
Jul 10, 2024

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Jul 8, 2024 •
edited
Loading

Description

If an error occurs while loading the configuration files, we must skip the evaluation.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin
fix(misconf): do not evaluate TF when a load error occurs
80bb355 
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@nikpivkin nikpivkin marked this pull request as ready for review July 8, 2024 06:19
@nikpivkin nikpivkin requested a review from simar7 as a code owner July 8, 2024 06:19
@simar7 simar7 added this pull request to the merge queue Jul 10, 2024
Merged via the queue into aquasecurity:main with commit f27c236 Jul 10, 2024
15 checks passed
@aqua-bot aqua-bot mentioned this pull request Jul 10, 2024
Merged
skahn007gl pushed a commit to skahn007gl/trivy that referenced this pull request Jul 23, 2024
@nikpivkin @skahn007gl
fix(misconf): do not evaluate TF when a load error occurs (aquasecuri…
977a78a 
…ty#7109)

Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@simar7 simar7 simar7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(misconf): Panic observed in passing of --tf-vars
2 participants
@nikpivkin @simar7