-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(java): correctly inherit version
and scope
from upper/root depManagement
and dependencies
into parents
#7541
fix(java): correctly inherit version
and scope
from upper/root depManagement
and dependencies
into parents
#7541
Conversation
depManagement
for dependencies
from parentversion
and scope
from root depManagement
in dependencies
version
and scope
from root depManagement
in dependenciesversion
and scope
from upper/root depManagement
and dependencies
into parents
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
I have found out that we have probably been making a mistake for a while. We're currently evaluating the parent POM first and then merge it into the child POM, but it seems correct to merge the |
I tested your changes with user issue (#7537). And looks like your changes work correctly 👍 |
Thanks for testing. It is rare that I correctly implement it once 🤣 |
Description
Forward
dependencyManagement
andProperties
field from root/upper POM into parents.dependencyManagement
should be used as non-root dependencyManagementSee new test for more details.
Related issues
version
andscope
from root DepManagement in parent dependencies #7539Related PRs
dependencyManagement
from root/child pom's for dependencies from parents [backport: release/v0.55] #7521Checklist