Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(report): Fix invalid URI in SARIF report #7645

Merged
merged 2 commits into from
Oct 7, 2024
Merged

fix(report): Fix invalid URI in SARIF report #7645

merged 2 commits into from
Oct 7, 2024

Conversation

pbaumard
Copy link
Contributor

@pbaumard pbaumard commented Oct 3, 2024

Description

Details are in #7644

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@pbaumard pbaumard requested a review from knqyf263 as a code owner October 3, 2024 12:33
@pbaumard pbaumard changed the title Fix invalid URI in SARIF report fix(report): Fix invalid URI in SARIF report Oct 3, 2024
@knqyf263 knqyf263 requested a review from DmitriyLewen October 4, 2024 06:40
DmitriyLewen
DmitriyLewen reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @pbaumard
Thanks for your work!

Left a couple comments.

@pbaumard @DmitriyLewen
Suggested change to add sarif prefix
a680ab2 
Co-authored-by: DmitriyLewen <91113035+DmitriyLewen@users.noreply.github.com>
@pbaumard pbaumard requested a review from DmitriyLewen October 7, 2024 09:05
DmitriyLewen
DmitriyLewen approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc. @knqyf263

@knqyf263 knqyf263 added this pull request to the merge queue Oct 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 7, 2024
@DmitriyLewen DmitriyLewen added this pull request to the merge queue Oct 7, 2024
Merged via the queue into aquasecurity:main with commit 015bb88 Oct 7, 2024
12 checks passed
@aqua-bot aqua-bot mentioned this pull request Oct 10, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@DmitriyLewen DmitriyLewen DmitriyLewen approved these changes

@knqyf263 knqyf263 Awaiting requested review from knqyf263 knqyf263 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbaumard @DmitriyLewen