Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add interface for accepting spikes from an external source #626

Closed
bcumming opened this issue Oct 15, 2018 · 5 comments
Closed

Add interface for accepting spikes from an external source #626

bcumming opened this issue Oct 15, 2018 · 5 comments
Assignees
Labels
co-sim Related to co-simulation work / SGA3 T5.5 enhancement

Comments

@bcumming
Copy link
Member

Take the interface and implementation that was written for the hackathon.

https://github.com/arbor-sim/arbor/tree/spike-external

@bcumming bcumming self-assigned this Oct 15, 2018
@halfflat
Copy link
Contributor

halfflat commented Feb 1, 2019

Having a look at what is required, I believe we need:

  • The external_connections_ code in communicator.hpp (though I would keep the source unsigned).
  • external_spike_callback in simulator and implementation class.
  • Customizable min_delay — though I think this should be done at simulator initialization time rather than after.
  • The make_event_queues overload in communicator.

I'd dearly like a less strongly-coupled solution for external spike exchange based on e.g. moving windows over per-simulator bundles of generated spikes and dynamic integration window size, but that's another story.

@halfflat
Copy link
Contributor

halfflat commented Feb 1, 2019

Oh, and I think we should extend the external_spike_callback interface so that it takes an argument for the minimum window of external events, i.e. a t such that any subsequent call to the callback provides events with time not less than t.

We can check that assertion and throw an error indicating desynchronization.

@halfflat
Copy link
Contributor

Might be a stretch goal, but I'd like to see this interface in the 0.2 release; adding the tag and we'll see how we go.

@halfflat halfflat self-assigned this Feb 26, 2019
@halfflat halfflat added the 0.2 label Feb 26, 2019
@halfflat
Copy link
Contributor

halfflat commented Mar 5, 2019

Removing 0.2 tag; will aim for 0.3.

@halfflat halfflat removed the 0.2 label Mar 5, 2019
@brenthuisman brenthuisman added the co-sim Related to co-simulation work / SGA3 T5.5 label Feb 4, 2021
@thorstenhater
Copy link
Contributor

🎉 closed by #2001

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
co-sim Related to co-simulation work / SGA3 T5.5 enhancement
Projects
None yet
Development

No branches or pull requests

4 participants