Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove the deprecated LogServiceBus...Dependency extensions #406

Closed
stijnmoreels opened this issue Jun 13, 2022 · 4 comments · Fixed by #551
Closed

Remove the deprecated LogServiceBus...Dependency extensions #406

stijnmoreels opened this issue Jun 13, 2022 · 4 comments · Fixed by #551
Assignees
Labels
breaking-change All issues that require to do a breaking chnage dependencies All issues related to dependencies good first issue Good for newcomers
Milestone

Comments

@stijnmoreels
Copy link
Member

Is your feature request related to a problem? Please describe.
Previous.y, we used the DependencyMeasurement to track Azure Service Bus dependencies and were not using the namespace of the entity.

Describe the solution you'd like
Remove the deprecated LogServiceBus...Dependency extensions in the Arcus.Observability.Telemetry.Core project that:

  • are using the DependencyMeasurement type
  • are missing the Azure Serivice Bus namespace endpoint

This is needed for the LogServiceBusQueueDependency, LogServiceBusTopicDependency and LogServiceBusDependency extensions.

@stijnmoreels stijnmoreels added this to the v3.0.0 milestone Jun 13, 2022
@stijnmoreels stijnmoreels added good first issue Good for newcomers dependencies All issues related to dependencies breaking-change All issues that require to do a breaking chnage labels Jun 13, 2022
@vincenttermaat
Copy link
Contributor

picking this up

@vincenttermaat
Copy link
Contributor

vincenttermaat commented Jul 8, 2022

  • are using the DependencyMeasurement type
  • are missing the Azure Serivice Bus namespace endpoint

Is this an example of an obsolete method that should NOT be removed?
As it uses DurationMeasurement.

@stijnmoreels
Copy link
Member Author

  • are using the DependencyMeasurement type
  • are missing the Azure Serivice Bus namespace endpoint

Is this an example of an obsolete method that should NOT be removed? As it uses DurationMeasurement.

No, those can also be removed, as they are already made deprecated in v2.5. So, its fine.

@stijnmoreels
Copy link
Member Author

Actually, any extension here that don't have an Azure Service Bus endpoint namespace, can be removed, along side extensions that still uses the DependencyMeasurement.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
breaking-change All issues that require to do a breaking chnage dependencies All issues related to dependencies good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants