From e989613958c4ee2ba0bf963f272498ee55cdaa20 Mon Sep 17 00:00:00 2001 From: Jorge Trujillo Date: Thu, 28 Nov 2024 14:48:36 +0100 Subject: [PATCH 1/2] Moving SDRAM.begin() on Arduino_H7_Video library --- libraries/Arduino_H7_Video/src/Arduino_H7_Video.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libraries/Arduino_H7_Video/src/Arduino_H7_Video.cpp b/libraries/Arduino_H7_Video/src/Arduino_H7_Video.cpp index f6199a18d..2e55bb562 100644 --- a/libraries/Arduino_H7_Video/src/Arduino_H7_Video.cpp +++ b/libraries/Arduino_H7_Video/src/Arduino_H7_Video.cpp @@ -89,6 +89,9 @@ int Arduino_H7_Video::begin() { textFont(Font_5x7); #endif + /* Configure SDRAM */ + SDRAM.begin(dsi_getFramebufferEnd()); // Moving this line from line 156 to here solves the artifacts issue + /* Video controller/bridge init */ _shield->init(_edidMode); @@ -152,9 +155,6 @@ int Arduino_H7_Video::begin() { #endif #endif - /* Configure SDRAM */ - SDRAM.begin(dsi_getFramebufferEnd()); //FIXME: SDRAM init after video controller init can cause display glitch at start-up - return 0; } From b46cb0bf7db9478b28a67cb5298664bca82b5fbf Mon Sep 17 00:00:00 2001 From: Jorge Date: Tue, 10 Dec 2024 13:08:18 +0100 Subject: [PATCH 2/2] Applying fix only on GIGA Target --- libraries/Arduino_H7_Video/src/Arduino_H7_Video.cpp | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libraries/Arduino_H7_Video/src/Arduino_H7_Video.cpp b/libraries/Arduino_H7_Video/src/Arduino_H7_Video.cpp index 2e55bb562..7f4b9570e 100644 --- a/libraries/Arduino_H7_Video/src/Arduino_H7_Video.cpp +++ b/libraries/Arduino_H7_Video/src/Arduino_H7_Video.cpp @@ -89,8 +89,10 @@ int Arduino_H7_Video::begin() { textFont(Font_5x7); #endif +#if defined(ARDUINO_GIGA) /* Configure SDRAM */ - SDRAM.begin(dsi_getFramebufferEnd()); // Moving this line from line 156 to here solves the artifacts issue + SDRAM.begin(dsi_getFramebufferEnd()); +#endif /* Video controller/bridge init */ _shield->init(_edidMode); @@ -152,6 +154,11 @@ int Arduino_H7_Video::begin() { disp_drv.sw_rotate = 1; lv_disp_drv_register(&disp_drv); /* Finally register the driver */ + #if !defined(ARDUINO_GIGA) + /* Configure SDRAM */ + SDRAM.begin(dsi_getFramebufferEnd()); //FIXME: SDRAM init after video controller init can cause display glitch at start-up + #endif + #endif #endif