Skip to content

Udp.h included in ArduinoCore-samd and in ArduinoCore-API #679

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
PatrickDekker98 opened this issue Aug 31, 2022 · 4 comments
Open

Udp.h included in ArduinoCore-samd and in ArduinoCore-API #679

PatrickDekker98 opened this issue Aug 31, 2022 · 4 comments

Comments

@PatrickDekker98
Copy link

Reference from ArduinoCore-API repo: arduino/ArduinoCore-API#171

Udp.h is included in Core-samd and core-api, while one of them uses #pragma once and the other include guards. This causes problems when including both of them.

error: redefinition of 'class arduino::UDP'

@matthijskooijman
Copy link
Collaborator

As indicated in the other issue, I think that Udp.h should probably just be removed from this repo.

@PatrickDekker98 Did you happen to have checked the contents of these files? Any functional differences (i.e. other than comments and spacing)?

@PatrickDekker98
Copy link
Author

Both classes are pure virtual and practically do the same thing: nothing
But, both classes have the same contents too

@PatrickDekker98
Copy link
Author

@matthijskooijman do you know why the arduinoCore-api is not a git submodule in this project?
To me development of arduinoCore-samd seems cumbersome, having to first download api, then samd, then creating a symlink from api to samd

@matthijskooijman
Copy link
Collaborator

See arduino/ArduinoCore-API#96 for some consideration about using sumbodules.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants