Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: allow --build-property for "upload", "monitor", etc. #2615

Closed
3 tasks done
egnor opened this issue May 28, 2024 · 0 comments · Fixed by #2693
Closed
3 tasks done

feat: allow --build-property for "upload", "monitor", etc. #2615

egnor opened this issue May 28, 2024 · 0 comments · Fixed by #2693
Assignees
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@egnor
Copy link

egnor commented May 28, 2024

(This is less important than #2602, and certainly less important than arduino/tooling-rfcs#9, if you're prioritizing.)

Describe the request

For arduino-cli compile, the --build-property flag is an escape hatch for situations when you need to "hack" part of the platform/board definition for some reason or other (change a definition, etc).

However, the upload and monitor commands also use build properties! Like, maybe you want to edit the uploader's command args a bit, or substitute in a different binary. But, these commands don't take --build-property.

(Arguably, --build-property should be global, though I'm not sure how the build properties framework interacts with the rest of the arduino-cli code base?)

Describe the current behavior

There's no way to override properties for upload or monitor steps.

Arduino CLI version

arduino-cli Version: 0.35.3 Commit: 95cfd65 Date: 2024-02-19T13:24:24Z

Operating system

N/A

Operating system version

All

Additional context

No response

Issue checklist

  • I searched for previous requests in the issue tracker
  • I verified the feature was still missing when using the nightly build
  • My request contains all necessary details
@egnor egnor added the type: enhancement Proposed improvement label May 28, 2024
@per1234 per1234 added the topic: code Related to content of the project itself label Jun 19, 2024
@cmaglie cmaglie added the conclusion: resolved Issue was resolved label Sep 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
3 participants