Call to undefined method stdClass::unsetRelation()

[antonioribeiro]

Description

We re getting this error when rendering blocks on preview. This is the line that might have introduced the bug.

Steps to reproduce

It's being generated by having browsers to related items in the block editor.

Versions

Twill version: 3.4
Laravel version: 11
PHP version: 8.3

/cc @Tofandel

[Tofandel]

$item is assumed to be a Model because it is coming from a relationship/query, which should absolutely have this method, why are you getting a stdClass instead of a model?

Did you somewhere maybe force the relation relatedItems or change the relatedItems method? Do you maybe have a global scope that's doing something it shouldn't?

[antonioribeiro]

Hard to tell, can't dive deep down this now. But it's a block editor with many repeaters and related browsers to multiple modules:

Browser::make()
    ->name($browserName ?? 'linked_item')
    ->label('Internal page')
    ->modules(Constants::BROWSER_ALL_ENDPOINTS)
    ->connectedTo($prefix . 'type', 'internal', ['keepAlive' => true]),

[Tofandel]

This might be coming from this line which is doing something it shouldn't

twill/src/Repositories/BlockRepository.php

Lines 46 to 59 in 3297066

	$relatedItems->push(
	(object) [
	'related' => $repository->getById($item['id']),
	'browser_name' => $browserName,
	]
	);
	} catch (ReflectionException $reflectionException) {
	Log::error($reflectionException);
	}
	});
	});
	$model->setRelation('relatedItems', $relatedItems);
	}

[antonioribeiro]

Yes, I just saw that $item is a stdClass that has the model in $item->related

[ifox]

@antonioribeiro by "when rendering blocks", do you mean inside Twill's editor, or your frontend controllers?

[antonioribeiro]

For some reason we only have this on preview, @ifox, I forgot to add to the ticket

[ifox]

This other PR might be related: #2535

[Tofandel]

I was looking at it but it's not this, it's the code I pointed to that stores objects into the relatedItem relation, sending a PR in 3 minutes

[Tofandel]

Btw @ifox I see a lot of Schema::hasTable(config('twill.related_table', 'twill_related')) in this class (which is a somewhat expensive query) running in a very heavy loop

Is there any actual case where this table would not exist? Isn't related a non disableable feature?

[ifox]

This was for backwards compatibility when the migrations were not all loaded automatically like they are now. This can be safely removed.

[Tofandel]

@antonioribeiro Any chance you could give a try to the PR?

Adding to your composer.json

    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/tofandel/twill"
        }
    ],
    "require": {
        "area17/twill": "dev-patch-18 as 3.4.1"
    }

And then composer upgrade

[antonioribeiro]

Sorry, I was already out of the office, I will try to look at this later, as I also don’t have my local environment with me 😁

[cambad]

Good morning here! I tried it with the PR @Tofandel, and I can confirm it is all good, I can preview the pages with related content!

Thanks, @Tofandel, for the fix 🙏🏽 🥳

cc @antonioribeiro