Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Oversample ADC_RANGE by 32 like ADC_INPUT #17975

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

barbudor
Copy link
Contributor

Description:

Related issue (if applicable): fixes #17974

I don't see any good reason while ADC_INPUT would use x32 oversampling but ADC_RANGE would use only x4

I suggest to increase oversampling for ADC_RANGE

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.6
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst arendst merged commit 119aeca into arendst:development Feb 17, 2023
@barbudor barbudor deleted the adc_range_oversampling_by_32 branch June 9, 2023 19:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants