From 98305bb9b0ce96f5cb5b367005570efd56e6eea7 Mon Sep 17 00:00:00 2001 From: Ari Selseng Date: Sun, 2 Feb 2020 17:45:42 +0100 Subject: [PATCH] Up phpunit and add composer attributes --- composer.json | 4 +++- phpunit.xml | 1 - tests/NorwegianBanksTest.php | 13 +++++++------ 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/composer.json b/composer.json index 45a9d0f..068cc33 100644 --- a/composer.json +++ b/composer.json @@ -1,5 +1,7 @@ { "name": "ariselseng/norwegianbanks", + "license": "MIT", + "version": "0.5", "autoload": { "psr-4": { "Ariselseng\\NorwegianBanks\\": "src/" @@ -12,7 +14,7 @@ "guzzlehttp/guzzle": "^6.5" }, "require-dev": { - "phpunit/phpunit": "4.*" + "phpunit/phpunit": "~7.0" }, "autoload-dev": { "psr-4": { diff --git a/phpunit.xml b/phpunit.xml index b423a7e..de3045d 100644 --- a/phpunit.xml +++ b/phpunit.xml @@ -8,7 +8,6 @@ convertWarningsToExceptions="true" processIsolation="false" stopOnFailure="false" - syntaxCheck="false" verbose="true" > diff --git a/tests/NorwegianBanksTest.php b/tests/NorwegianBanksTest.php index 5a4126e..58613a5 100644 --- a/tests/NorwegianBanksTest.php +++ b/tests/NorwegianBanksTest.php @@ -5,8 +5,13 @@ use Ariselseng\NorwegianBanks\NorwegianBanks; use Ariselseng\NorwegianBanks\NorwegianBanksStatic; -class NorwegianBanksTest extends \PHPUnit_Framework_TestCase +class NorwegianBanksTest extends \PHPUnit\Framework\TestCase { + private $norwegianBanks; + protected $notRealAccountNumber = '1234.56.78903'; + protected $notRealAccountNumberWithSpaces = '1234 56 78903'; + protected $notRealAccountNumberUnformatted = '12345678903'; + protected $accounts = [ [ 'bankCode' => 'DNBANOKK', @@ -21,13 +26,9 @@ class NorwegianBanksTest extends \PHPUnit_Framework_TestCase 'number' => '3000.27.79419' ], ]; - protected $notRealAccountNumber = '1234.56.78903'; - protected $notRealAccountNumberWithSpaces = '1234 56 78903'; - protected $notRealAccountNumberUnformatted = '12345678903'; - private $norwegianBanks; - public function __construct() + public function setUp() { $this->norwegianBanks = new NorwegianBanks(); }