Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bug]: rockchip-rk3588.conf overrides OVERLAY_PREFIX #7482

Open
1 of 2 tasks
bmx666 opened this issue Nov 15, 2024 · 1 comment
Open
1 of 2 tasks

[Bug]: rockchip-rk3588.conf overrides OVERLAY_PREFIX #7482

bmx666 opened this issue Nov 15, 2024 · 1 comment
Labels
Bug Something isn't working as it should

Comments

@bmx666
Copy link

bmx666 commented Nov 15, 2024

What happened?

In file config/sources/families/rockchip-rk3588.conf

OVERLAY_PREFIX='rockchip-rk3588'

It must use default definition only, without overriding

OVERLAY_PREFIX="${OVERLAY_PREFIX:-"rockchip-rk3588"}" # default to 'rockchip-rk3588' if not set by board

How to reproduce?

define custom OVERLAY_PREFIX in config/boards that depends on rockchip-rk3588.

For example, config/boards/rock-5b.conf

BOARDFAMILY="rockchip-rk3588"
OVERLAY_PREFIX="rock-5b"

In generated image, in file /boot/armbianEnv.txt

overlay_prefix=rockchip-rk3588

But it must be

overlay_prefix=rock-5b

Branch

main (main development branch)

On which host OS are you running the build script and observing this problem?

Ubuntu 24.04 Noble

Are you building on Windows WSL2?

  • Yes, my Ubuntu/Debian/OtherOS is running on WSL2

Relevant log URL

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@bmx666 bmx666 added the Bug Something isn't working as it should label Nov 15, 2024
Copy link
Contributor

github-actions bot commented Nov 15, 2024

Jira ticket: AR-2534

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug Something isn't working as it should
Development

No branches or pull requests

1 participant