Skip to content

Commit 0ad494e

Browse files
committed
fix(review): code review fix in type string
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
1 parent 244ba8a commit 0ad494e

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

pkg/middleend/qos_test.go

+9-9
Original file line numberDiff line numberDiff line change
@@ -949,42 +949,42 @@ func TestMiddleEnd_GetQosVolume(t *testing.T) {
949949

950950
func TestMiddleEnd_StatsQosVolume(t *testing.T) {
951951
tests := map[string]struct {
952-
in *_go.ObjectKey
952+
in string
953953
out *pb.StatsQosVolumeResponse
954954
spdk []string
955955
errCode codes.Code
956956
errMsg string
957957
}{
958-
"empty QoS volume id is not allowed ": {
959-
in: &_go.ObjectKey{Value: ""},
958+
"empty QoS volume name is not allowed ": {
959+
in: "",
960960
out: nil,
961961
spdk: []string{},
962962
errCode: codes.Unknown,
963963
errMsg: "missing required field: name",
964964
},
965965
"unknown QoS volume Id": {
966-
in: &_go.ObjectKey{Value: "unknown-qos-volume-id"},
966+
in: "unknown-qos-volume-id",
967967
out: nil,
968968
spdk: []string{},
969969
errCode: codes.NotFound,
970970
errMsg: fmt.Sprintf("unable to find key %s", "unknown-qos-volume-id"),
971971
},
972972
"SPDK call failed": {
973-
in: &_go.ObjectKey{Value: testQosVolumeName},
973+
in: testQosVolumeName,
974974
out: nil,
975975
spdk: []string{`{"id":%d,"error":{"code":1,"message":"some internal error"}}`},
976976
errCode: status.Convert(spdk.ErrFailedSpdkCall).Code(),
977977
errMsg: status.Convert(spdk.ErrFailedSpdkCall).Message(),
978978
},
979979
"SPDK call result false": {
980-
in: &_go.ObjectKey{Value: testQosVolumeName},
980+
in: testQosVolumeName,
981981
out: nil,
982982
spdk: []string{`{"id":%d,"error":{"code":0,"message":""},"result":{"tick_rate": 3300000000,"ticks": 5,"bdevs":[]}}`},
983983
errCode: status.Convert(spdk.ErrUnexpectedSpdkCallResult).Code(),
984984
errMsg: status.Convert(spdk.ErrUnexpectedSpdkCallResult).Message(),
985985
},
986986
"successful QoS volume stats": {
987-
in: &_go.ObjectKey{Value: testQosVolumeName},
987+
in: testQosVolumeName,
988988
out: &pb.StatsQosVolumeResponse{
989989
Stats: &pb.VolumeStats{
990990
ReadBytesCount: 36864,
@@ -998,7 +998,7 @@ func TestMiddleEnd_StatsQosVolume(t *testing.T) {
998998
errMsg: "",
999999
},
10001000
"malformed name": {
1001-
in: &_go.ObjectKey{Value: "-ABC-DEF"},
1001+
in: "-ABC-DEF",
10021002
out: nil,
10031003
spdk: []string{},
10041004
errCode: codes.Unknown,
@@ -1012,7 +1012,7 @@ func TestMiddleEnd_StatsQosVolume(t *testing.T) {
10121012

10131013
testEnv.opiSpdkServer.volumes.qosVolumes[testQosVolumeName] = testQosVolume
10141014

1015-
request := &pb.StatsQosVolumeRequest{Name: tt.in.Value}
1015+
request := &pb.StatsQosVolumeRequest{Name: tt.in}
10161016
response, err := testEnv.client.StatsQosVolume(testEnv.ctx, request)
10171017

10181018
if !proto.Equal(tt.out, response) {

0 commit comments

Comments
 (0)