Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Calling FFmpegKit cancel method 4 times kills the application #129

Closed
tanersener opened this issue Aug 18, 2021 · 1 comment
Closed

Calling FFmpegKit cancel method 4 times kills the application #129

tanersener opened this issue Aug 18, 2021 · 1 comment
Assignees
Labels
android Affect Android platform apple Affect Apple platforms bug Something isn't working fixed-in-v4.5 Fixed in release v4.5 library Affects the library v4.4 Affects v4.4 release

Comments

@tanersener
Copy link
Collaborator

Description
Calling FFmpegKit.cancel() 4 times, without any parameters kills the application.

Expected behavior
None of the API methods should cause the application to crash.

Current behavior
Application crashes.

To Reproduce
Call FFmpegKit.cancel() 4 times, without any method parameters.

Expected behavior
No crash.

Logs
No logs are printed to console.

Environment

  • Platform: Android
  • Architecture: arm-v7a, arm-v7a-neon, arm64-v8a, x86, x86_64
  • Version: v4.4
  • Android Studio version: 2020.3.1
  • Android NDK version: r22b

Other
The issue was discovered on Android but it affects all platforms. Initial investigation show that the sigterm_handler method is responsible of that crash. The implementation coming from ffmpeg calls the exit method on the 4th call. See sigterm_handler method.

@tanersener tanersener self-assigned this Aug 18, 2021
@tanersener tanersener added android Affect Android platform apple Affect Apple platforms bug Something isn't working library Affects the library v4.4 Affects v4.4 release labels Aug 18, 2021
@tanersener tanersener added the fixed-on-development Fixed on the development branch. Not released yet. label Aug 18, 2021
@tanersener
Copy link
Collaborator Author

Fixed in the development.

@arthenica arthenica deleted a comment from sammi06 Aug 20, 2021
@tanersener tanersener added fixed-in-v4.5 Fixed in release v4.5 and removed fixed-on-development Fixed on the development branch. Not released yet. labels Sep 20, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
android Affect Android platform apple Affect Apple platforms bug Something isn't working fixed-in-v4.5 Fixed in release v4.5 library Affects the library v4.4 Affects v4.4 release
Projects
None yet
Development

No branches or pull requests

1 participant