Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bokeh deprecation warnings #1657

Closed
OriolAbril opened this issue Apr 9, 2021 · 7 comments
Closed

Bokeh deprecation warnings #1657

OriolAbril opened this issue Apr 9, 2021 · 7 comments
Assignees
Labels

Comments

@OriolAbril
Copy link
Member

I saw

BokehDeprecationWarning: Dash() was deprecated in Bokeh 2.3.0 and will be removed, use Scatter(marker='dash') instead.
BokehDeprecationWarning: Cross() was deprecated in Bokeh 2.3.0 and will be removed, use Scatter(marker='cross') instead.

in the docs build. We should search for all occurrences of these in the codebase and update them.

@migunasekera
Copy link

Hi @OriolAbril, I'd be interested in contributing, could I be assigned to this?

@OriolAbril
Copy link
Member Author

Done, thanks! Let us know if you have any doubts

@Random-coder123
Copy link

Hi, I would like to contribute to this, could I please be assigned? Thank you

@OriolAbril
Copy link
Member Author

Hi @Random-coder123, the issue is already assigned to @migunasekera and per our contributing guidelines would only be available if in 10 days there were to be no updates at all or @migunasekera commented here to unassign from the issue.

There are many other tasks to work on though, would #1188 for example be interesting to you? Is there a particular topic on which you'd like to work?

@vikramnagashoka
Copy link
Contributor

vikramnagashoka commented Apr 29, 2021

Hi @OriolAbril ,
I would like to pick up this task. Can I please be assigned to this ?
Thanks

@OriolAbril
Copy link
Member Author

As it has been already two weeks since the last comment there has been no activity I have assigned it to you. As always, let us know if you have any doubts.

@vikramnagashoka
Copy link
Contributor

Thanks for assigning it to me. I have created a pull request for the same here.
https://github.com/arviz-devs/arviz/pull/1683

OriolAbril pushed a commit that referenced this issue Jun 14, 2021
* remove Bokeh deprecation warnings

* remove comments

* change input source for marker to be variable

* fix errors related to pylint test

* fix pylint build errors

* commit after black

* Update CHANGELOG.md

Co-authored-by: Ari Hartikainen <ahartikainen@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants