Skip to content

Commit f861bd7

Browse files
authored
Merge pull request #13 from asarkar/issue-12
Fix issue-12: Parameter injection of Resources does not clean up
2 parents 897d0d6 + 4a2d7e9 commit f861bd7

14 files changed

+57
-12
lines changed

build.gradle.kts

+8
Original file line numberDiff line numberDiff line change
@@ -138,3 +138,11 @@ nexusPublishing {
138138
}
139139
}
140140
}
141+
142+
tasks.withType<Test> {
143+
useJUnitPlatform()
144+
testLogging {
145+
showStandardStreams = true
146+
}
147+
exclude("**/ignore/**")
148+
}

gradle.properties

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ ktlintVersion=10.2.1
1010
nexusPluginVersion=1.1.0
1111

1212
projectGroup=com.asarkar.grpc
13-
projectVersion=1.2.1
13+
projectVersion=1.2.2
1414
projectDescription=JUnit5 Extension that can automatically release gRPC resources at the end of the test
1515
licenseName=Apache-2.0
1616
licenseUrl=http://www.apache.org/licenses/LICENSE-2.0.txt

src/main/kotlin/com/asarkar/grpc/test/GrpcCleanupExtension.kt

+5-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,11 @@ class GrpcCleanupExtension :
7070
parameterCtx.declaringExecutable.isAnnotationPresent(BeforeAll::class.java)
7171
)
7272

73-
return Resources().also { extensionCtx.resources.getOrPut(once, { mutableListOf() }).add(it) }
73+
return Resources().also { resources ->
74+
extensionCtx.resources = extensionCtx.resources.also {
75+
it.getOrPut(once) { mutableListOf() }.add(resources)
76+
}
77+
}
7478
}
7579

7680
override fun beforeAll(ctx: ExtensionContext) {

src/test/kotlin/com/asarkar/grpc/test/GrpcCleanupExtensionIntegrationTests.kt

+10
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,15 @@
11
package com.asarkar.grpc.test
22

3+
import com.asarkar.grpc.test.ignore.ExampleTestCase
4+
import com.asarkar.grpc.test.ignore.ExampleTestCase10
5+
import com.asarkar.grpc.test.ignore.ExampleTestCase2
6+
import com.asarkar.grpc.test.ignore.ExampleTestCase3
7+
import com.asarkar.grpc.test.ignore.ExampleTestCase4
8+
import com.asarkar.grpc.test.ignore.ExampleTestCase5
9+
import com.asarkar.grpc.test.ignore.ExampleTestCase6
10+
import com.asarkar.grpc.test.ignore.ExampleTestCase7
11+
import com.asarkar.grpc.test.ignore.ExampleTestCase8
12+
import com.asarkar.grpc.test.ignore.ExampleTestCase9
313
import io.grpc.ManagedChannel
414
import io.grpc.Server
515
import org.assertj.core.api.Assertions.assertThat

src/test/kotlin/com/asarkar/grpc/test/ExampleTestCase.kt src/test/kotlin/com/asarkar/grpc/test/ignore/ExampleTestCase.kt

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1-
package com.asarkar.grpc.test
1+
package com.asarkar.grpc.test.ignore
22

3+
import com.asarkar.grpc.test.GrpcCleanupExtension
4+
import com.asarkar.grpc.test.Resources
35
import io.grpc.ManagedChannel
46
import io.grpc.Server
57
import org.junit.jupiter.api.Test

src/test/kotlin/com/asarkar/grpc/test/ExampleTestCase10.kt src/test/kotlin/com/asarkar/grpc/test/ignore/ExampleTestCase10.kt

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1-
package com.asarkar.grpc.test
1+
package com.asarkar.grpc.test.ignore
22

3+
import com.asarkar.grpc.test.GrpcCleanupExtension
4+
import com.asarkar.grpc.test.Resources
5+
import com.asarkar.grpc.test.TestUtils
36
import org.assertj.core.api.Assertions.assertThat
47
import org.junit.jupiter.api.BeforeAll
58
import org.junit.jupiter.api.BeforeEach

src/test/kotlin/com/asarkar/grpc/test/ExampleTestCase2.kt src/test/kotlin/com/asarkar/grpc/test/ignore/ExampleTestCase2.kt

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1-
package com.asarkar.grpc.test
1+
package com.asarkar.grpc.test.ignore
22

3+
import com.asarkar.grpc.test.GrpcCleanupExtension
4+
import com.asarkar.grpc.test.Resources
5+
import com.asarkar.grpc.test.TestUtils
36
import org.assertj.core.api.Assertions.assertThat
47
import org.junit.jupiter.api.Test
58
import org.junit.jupiter.api.extension.ExtendWith

src/test/kotlin/com/asarkar/grpc/test/ExampleTestCase3.kt src/test/kotlin/com/asarkar/grpc/test/ignore/ExampleTestCase3.kt

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1-
package com.asarkar.grpc.test
1+
package com.asarkar.grpc.test.ignore
22

3+
import com.asarkar.grpc.test.GrpcCleanupExtension
4+
import com.asarkar.grpc.test.Resources
35
import org.junit.jupiter.api.Test
46
import org.junit.jupiter.api.TestInstance
57
import org.junit.jupiter.api.extension.ExtendWith

src/test/kotlin/com/asarkar/grpc/test/ExampleTestCase4.kt src/test/kotlin/com/asarkar/grpc/test/ignore/ExampleTestCase4.kt

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1-
package com.asarkar.grpc.test
1+
package com.asarkar.grpc.test.ignore
22

3+
import com.asarkar.grpc.test.GrpcCleanupExtension
4+
import com.asarkar.grpc.test.Resources
35
import org.junit.jupiter.api.Test
46
import org.junit.jupiter.api.extension.ExtendWith
57

src/test/kotlin/com/asarkar/grpc/test/ExampleTestCase5.kt src/test/kotlin/com/asarkar/grpc/test/ignore/ExampleTestCase5.kt

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1-
package com.asarkar.grpc.test
1+
package com.asarkar.grpc.test.ignore
22

3+
import com.asarkar.grpc.test.GrpcCleanupExtension
4+
import com.asarkar.grpc.test.Resources
35
import org.assertj.core.api.Assertions.assertThat
46
import org.junit.jupiter.api.Test
57
import org.junit.jupiter.api.extension.ExtendWith

src/test/kotlin/com/asarkar/grpc/test/ExampleTestCase6.kt src/test/kotlin/com/asarkar/grpc/test/ignore/ExampleTestCase6.kt

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1-
package com.asarkar.grpc.test
1+
package com.asarkar.grpc.test.ignore
22

3+
import com.asarkar.grpc.test.GrpcCleanupExtension
4+
import com.asarkar.grpc.test.Resources
35
import org.junit.jupiter.api.Test
46
import org.junit.jupiter.api.extension.ExtendWith
57

src/test/kotlin/com/asarkar/grpc/test/ExampleTestCase7.kt src/test/kotlin/com/asarkar/grpc/test/ignore/ExampleTestCase7.kt

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1-
package com.asarkar.grpc.test
1+
package com.asarkar.grpc.test.ignore
22

3+
import com.asarkar.grpc.test.GrpcCleanupExtension
4+
import com.asarkar.grpc.test.Resources
35
import org.junit.jupiter.api.Test
46
import org.junit.jupiter.api.TestInstance
57
import org.junit.jupiter.api.extension.ExtendWith

src/test/kotlin/com/asarkar/grpc/test/ExampleTestCase8.kt src/test/kotlin/com/asarkar/grpc/test/ignore/ExampleTestCase8.kt

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1-
package com.asarkar.grpc.test
1+
package com.asarkar.grpc.test.ignore
22

3+
import com.asarkar.grpc.test.GrpcCleanupExtension
4+
import com.asarkar.grpc.test.Resources
35
import org.junit.jupiter.api.Test
46
import org.junit.jupiter.api.extension.ExtendWith
57

src/test/kotlin/com/asarkar/grpc/test/ExampleTestCase9.kt src/test/kotlin/com/asarkar/grpc/test/ignore/ExampleTestCase9.kt

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1-
package com.asarkar.grpc.test
1+
package com.asarkar.grpc.test.ignore
22

3+
import com.asarkar.grpc.test.GrpcCleanupExtension
4+
import com.asarkar.grpc.test.Resources
5+
import com.asarkar.grpc.test.TestUtils
36
import io.grpc.ManagedChannel
47
import org.assertj.core.api.Assertions.assertThat
58
import org.junit.jupiter.api.BeforeAll

0 commit comments

Comments
 (0)