Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Allow theme to control style and placement of document title #135

Closed
mojavelinux opened this issue May 21, 2015 · 4 comments
Closed

Allow theme to control style and placement of document title #135

mojavelinux opened this issue May 21, 2015 · 4 comments
Assignees
@mojavelinux
Labels
enhancement
Milestone
v1.5.0.alpha.7

Comments

@mojavelinux
Copy link
Member

Allow the theme to control the style of the document title. This includes the following:

  • font size, style and color
  • y position (or offset from top)
  • alignment

We should also have similar settings (or allow them to inherit) for the author and revision info.
@mojavelinux mojavelinux added this to the v1.5.0 milestone May 21, 2015
@mojavelinux mojavelinux mentioned this issue May 21, 2015
Closed
@mojavelinux
Copy link
Member Author

The font size, style and color are currently controlled using the heading_*_h1 theme keys. However, this is not clear for a designer. Instead, there should be a dedicated key in the them for the title page.

@mojavelinux mojavelinux self-assigned this May 23, 2015
@mojavelinux mojavelinux changed the title Allow theme to control style of document title Allow theme to control style and placement of document title May 24, 2015
@mojavelinux
Copy link
Member Author

Also the text_transform.

@mojavelinux
Copy link
Member Author

I think it's better to use margin_top than y position. However, we could support both options (with y position getting precedent).

mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue May 24, 2015
@mojavelinux
resolves asciidoctor#135 allow theme to control layout of title page
50803dc 
- absolute top position for title
- margin top & bottom for all text elements
- text alignment
- revision info delimiter
- absolute top position for image logo
- rename title-logo attribute to title-logo-image
- parse title-logo-image attribute value as image macro (if used)
- title logo image size and alignment
- update example to include subtitle and logo image scaling
- fix theme_font so all properties are inherited (except heading size)
- minor code cleanups
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue May 25, 2015
@mojavelinux
resolves asciidoctor#135 allow theme to control layout of title page
329859c 
- absolute top position for title
- margin top & bottom for all text elements
- text alignment
- revision info delimiter
- absolute top position for image logo
- rename title-logo attribute to title-logo-image
- parse title-logo-image attribute value as image macro (if used)
- title logo image size and alignment
- update example to include subtitle and logo image scaling
- fix theme_font so all properties are inherited (except heading size)
- minor code cleanups
@mojavelinux
Copy link
Member Author

We can't support the text_transform style until #141 is merged.

mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue May 25, 2015
@mojavelinux
resolves asciidoctor#135 allow theme to control layout of title page
7dcb93c 
- absolute top position for title
- margin top & bottom for all text elements
- text alignment
- revision info delimiter
- absolute top position for image logo
- rename title-logo attribute to title-logo-image
- parse title-logo-image attribute value as image macro (if used)
- title logo image size and alignment
- update example to include subtitle and logo image scaling
- fix theme_font so all properties are inherited (except heading size)
- minor code cleanups
mojavelinux added a commit that referenced this issue May 25, 2015
@mojavelinux
Merge pull request #146 from mojavelinux/issue-135
2566c64 
resolves #135 allow theme to control layout of title page
@mojavelinux mojavelinux mentioned this issue May 25, 2015
Closed
@ogmios-voice ogmios-voice mentioned this issue Dec 31, 2018
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@mojavelinux mojavelinux

Labels
enhancement
Projects
None yet
Milestone
v1.5.0.alpha.7
Development

No branches or pull requests
2 participants
@mojavelinux @graphitefriction