You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The start_new_chapter callback should always be executed when a chapter is started. Currently, this callback is not executed if the cursor is at the top of the page when the chapter begins. While this may be okay for the built-in behavior, it's a severe limitation for extensions that must perform other work at the chapter transitions.
The start_new_chapter callback will now be responsible for checking if the cursor is already at the top of a new page, including the built-in implementation.
The text was updated successfully, but these errors were encountered:
Here's a sample document that reproduces the issue:
= Document Title
:doctype: book
----
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
line
----
== Chapter Title
content
The start_new_chapter method is never called due to the cursor placement after the listing block is rendered.
mojavelinux
added a commit
to mojavelinux/asciidoctor-pdf
that referenced
this issue
Aug 27, 2016
… chapter transition
- ensure start_new_chapter always get executed at a chapter transition
- only start new page in start_new_page if cursor is not at page top
- minor code optimization
… chapter transition
- ensure start_new_chapter always get executed at a chapter transition
- only start new page in start_new_page if cursor is not at page top
- minor code optimization
… chapter transition (PR asciidoctor#525)
- ensure start_new_chapter always get executed at a chapter transition
- only start new page in start_new_page if cursor is not at page top
- minor code optimization
The start_new_chapter callback should always be executed when a chapter is started. Currently, this callback is not executed if the cursor is at the top of the page when the chapter begins. While this may be okay for the built-in behavior, it's a severe limitation for extensions that must perform other work at the chapter transitions.
The start_new_chapter callback will now be responsible for checking if the cursor is already at the top of a new page, including the built-in implementation.
The text was updated successfully, but these errors were encountered: